Implement ALTER TYPE RENAME VALUE / ADD VALUE#433
Merged
kyleconroy merged 2 commits intomasterfrom Apr 5, 2020
Merged
Conversation
This is a backport of the implementation from sql/catalog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests actually includes two parallel implementations of ALTER TYPE, one for the legacy
internal/catalogpackage, and one for the newinternal/sql/catalogpackage. I really need to port theinternal/dinosqlpackage over to the new catalog so I don't need to waste time doing things twice.Fix #428